Skip to content

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Aug 9, 2025

add more info to the panic so that it can be triaged more easily

What I did

fix #4725

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

add more info to the panic so that it can be triaged more easily
Copy link
Collaborator

@pcaversaccio pcaversaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The related issue is #4725. I mean it fixes the problem somehow, was more wondering if we could guess instead the name of the correct argument name?

Copy link

codecov bot commented Aug 9, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.07%. Comparing base (232e27f) to head (d0ad40c).

Files with missing lines Patch % Lines
vyper/semantics/types/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4726   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files         131      131           
  Lines       19082    19082           
  Branches     3318     3318           
=======================================
  Hits        17760    17760           
  Misses        891      891           
  Partials      431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Method must be implemented by the inherited class
2 participants