-
Notifications
You must be signed in to change notification settings - Fork 25
Add a11y guidance for user agents #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MasterKale
wants to merge
19
commits into
main
Choose a base branch
from
229-horizontal-review-accessibility
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e06dd05
Add a11y guidance for user agents
MasterKale a245634
Merge branch 'main' into 229-horizontal-review-accessibility
MasterKale 05ecad5
Change "consent" -> "permission"
MasterKale fe2bb38
Merge branch 'main' into 229-horizontal-review-accessibility
MasterKale d3691d7
Merge branch 'main' into 229-horizontal-review-accessibility
marcoscaceres 4d54404
Merge branch 'main' into 229-horizontal-review-accessibility
MasterKale 8e19913
Update copy for PR feedback
MasterKale 291797a
Apply suggestions from code review
marcoscaceres 3cc117e
Merge branch 'main' into 229-horizontal-review-accessibility
marcoscaceres d292753
Merge branch 'main' into 229-horizontal-review-accessibility
marcoscaceres 698bc50
Merge branch 'main' into 229-horizontal-review-accessibility
marcoscaceres b8d011c
Merge branch 'main' into 229-horizontal-review-accessibility
MasterKale e1c0743
Incorporate feedback
MasterKale 4bf85e7
Point to issuance and presentation in the spec
MasterKale 5357eec
Use regular dashes to match the rest of the doc
MasterKale 0892b30
Merge branch 'main' into 229-horizontal-review-accessibility
MasterKale fa0d26c
Remove informative class from a11y section
MasterKale 103e713
Merge branch 'main' into 229-horizontal-review-accessibility
MasterKale 0348eea
Incorporate PR feedback
MasterKale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"credential choosers" are out of scope for this API, this it is the responsibility of the underlying platform to display them.
Not sure if this actually fits here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, good point. This should really be about user agents, that might put some UI before invoking the credential chooser, making that UI accessible. Could a simple replacement here work?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with keeping [=credential choosers=] here... the API still needs to present a credential chooser because Cred Man explicitly requires it as part of the get a credential steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dug into the CredMan definition that [=credential choosers=] ends up getting linked to, and it's to a section on User Mediated Selection that talks about credential choosers as something that User Agents implement:
https://www.w3.org/TR/credential-management-1/#user-mediated-selection
This must be what @marcoscaceres is referring to above (I'm making this connection more for my benefit.) So perhaps it's okay to keep the mention of credential choosers here. @mohamedamir might this change your mind about this particular section of accessibility guidance?