-
Notifications
You must be signed in to change notification settings - Fork 28
Make user mediation implicit and always required #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
After w3c-fedid/digital-credentials#392, mediation doesn't need to be specified.
|
Although I agree with this behavior, I think it should be defaulted by the CredMan spec instead. So we would register the default there instead. That follows the convention already set forth in the underlying spec. |
@marcoscaceres |
No, absolutely not. Right, I see now more clearly what you are going for! I'm worried were are "monkey patching" though, which we should avoid. What I'm trying to figure out is how do we handle this in Cred Man if we need to (i.e., just looking at all options). |
Sure, sounds good. Looking at the Another observation is Step 13.9 conditional mediation with null credentials isn't resolved. Having said that, CredMan spec doesn't impose any constraints on the So I don't think there is anything to be done at the CredMan level. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the Digital Credentials API by making user mediation implicit and always required, removing the need for developers to explicitly specify mediation: 'required'. The change eliminates the requirement to set the mediation parameter and prevents TypeErrors from being thrown when it's absent or set to other values, making the API more developer-friendly while maintaining user control.
Key changes:
- User mediation is now always performed as if
mediation: 'required'were specified - The
mediationparameter is ignored rather than validated - User agents must not throw TypeError for absent or non-required mediation values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcoscaceres
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the suggested change, this seems good.
…deals with create().
Co-authored-by: Ted Thibodeau Jr <[email protected]>
This change simplifies the Digital Credentials API by making user mediation an implicit, non-overridable behavior.
Currently, the specification requires developers to explicitly set
mediation: 'required'forget()andcreate()calls. This adds unnecessary boilerplate.With this change:
mediation: 'required'were specified.mediationparameter inCredentialRequestOptionsandCredentialCreationOptionsis ignored.mediationmember is absent or has another value.This simplifies the API for developers and aligns with the goal of making
requiredmediation the default, non-overridable behavior.Closes #177
Closes #384
The following tasks have been completed:
Implementation commitment:
Documentation and checks
Preview | Diff