Let specs define their own default mediation requirement #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
marcoscaceres
commented
Aug 23, 2024
marcoscaceres
commented
Aug 23, 2024
| </blockquote> | ||
| </div> | ||
|
|
||
| Additionally, a specification can add its own set of restriction around what mediations are allowed to be passed into the API. |
Member
Author
There was a problem hiding this comment.
this should probably be more explicit about the internal methods.
marcoscaceres
commented
Aug 24, 2024
marcoscaceres
commented
Aug 24, 2024
nsatragno
requested changes
Sep 13, 2024
Member
nsatragno
left a comment
nsatragno
left a comment
There was a problem hiding this comment.
I don't know how I missed this -- sorry.
I think we don't actually need to do this and have commented on the issue, but left some comments in case we still want to pursue it.
| 1. If |interfaces| is [=set/empty=], then return[=a promise rejected with=] | ||
| a "{{NotSupportedError}}" {{DOMException}}. | ||
|
|
||
| 1. If |options|.{{CredentialRequestOptions/mediation}} was not passed, |
Member
There was a problem hiding this comment.
nit: I believe
Suggested change
| 1. If |options|.{{CredentialRequestOptions/mediation}} was not passed, | |
| 1. If |options|.{{CredentialRequestOptions/mediation}} is `null` or `undefined`, |
might be more accurate.
|
|
||
| 1. Let |interfaces| be the [=set=] of |options|' <a>relevant credential interface objects</a>. | ||
|
|
||
| 1. If |options|.{{CredentialRequestOptions/mediation}} was not passed, |
|
|
||
| Credential interfaces can define a <dfn for="Credential" export>default get mediation</dfn> and | ||
| <dfn for="Credential" export>default create mediation</dfn> as an {{CredentialMediationRequirement}} enum value. | ||
| Together, they establish the default [[#mediation-requirements]] for when none are supplied by the developer. |
Member
There was a problem hiding this comment.
What happens when two credential types define two different mediation types?
Member
Author
There was a problem hiding this comment.
each spec defines its own, so they won't conflict. It will just be, like X defaults to "optional" and Y defaults to "required".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #256
The following tasks have been completed:
Implementation commitment:
Preview | Diff