SVNmentions v1.0 implementation report #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrvo
commented
Apr 4, 2025
Comment on lines
+6
to
+7
| Source Code repo URL(s) (optional): | ||
| * [ ] 100% open source implementation |
| ### Request Verification (3.2.1) | ||
|
|
||
| * [x] Verifies source and target are valid URLs, rejecting with HTTP 400 (MUST) | ||
| * [x] Verifies that target is a valid resource for which the receiver accepts Webmentions, rejecting with HTTP 400 (SHOULD) |
There was a problem hiding this comment.
Has some target verification. Has the carrvo/SVNmentions#5 for an additional verification.
Comment on lines
+51
to
+57
| * [x] Accepts a Webmention where the target URL is in an `<a>` tag | ||
| * [x] Accepts a Webmention where the target URL is in an `<img>` tag | ||
| * [x] Accepts a Webmention where the target URL is in an `<video>` tag | ||
| * [x] Accepts a Webmention where the target URL is in an `<audio>` tag | ||
| * [ ] Rejects a Webmention where the target URL is in the document as text | ||
| * [ ] Rejects a Webmention where the target URL is in an `<a>` tag **inside an HTML comment** | ||
| * [x] Rejects a Webmention where the target URL is not in the document |
There was a problem hiding this comment.
Does a raw text search on the source for the target.
Comment on lines
+64
to
+65
| * [x] The receiver recognizes that the source URL is a "comment" or "reply" to the post | ||
| * [ ] using HTML markup: __________ |
There was a problem hiding this comment.
Assumes all are comments.
What does using HTML markup refer to? The markup that the receiver uses on the target? Or the markup that it searches for on the source?
carrvo
commented
Apr 8, 2025
| Implementation Classes (Sender and/or Receiver): Sender | ||
|
|
||
|
|
||
| ## Sending |
There was a problem hiding this comment.
Untested but filled out based on expectation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.