Open
Conversation
davin111
reviewed
Sep 30, 2023
| val entity = userRepository.findByUsername(accessToken.reversed()) ?: throw AuthenticateException() | ||
|
|
||
| return User(entity) | ||
| val userList = userRepository.findAll() |
Member
There was a problem hiding this comment.
이런 식으로 DB 에 있는 유저를 다 찾아오면, 지금처럼 가볍게 테스트하는 수준에서는 동작할 수도 있지만 실제 서비스를 하여 유저가 조금만 많아져도 성능상 문제가 생길 수 있습니다. 애초에 적절한 유저만 찾도록 DB 쿼리를 하는 것이 필요합니다. 업데이트된 세미나장의 과제0 코드를 참고해보세요.
PFCJeong
force-pushed
the
master
branch
2 times, most recently
from
1a8e813 to
f420cff
Compare
PFCJeong
force-pushed
the
master
branch
3 times, most recently
from
633df04 to
66e14db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
intellij에서 pr 생성이 권한이 없다는 메세지와 함께 이루어지지 않았기에 부득이하게 현재 버전의 레포지토리를 포크하여서 UserServiceImpl과 UserController 파일만 수정했습니다. 죄송합니다.