Open
Conversation
PFCJeong
approved these changes
Sep 26, 2023
| fun handleException(e: UserException): ResponseEntity<Unit> { | ||
| TODO() | ||
| return when(e){ | ||
| is AuthenticateException -> ResponseEntity(HttpStatus.UNAUTHORIZED) |
| return User(username = username,image=image) | ||
| } | ||
|
|
||
| override fun signIn(username: String, password: String): User { |
Member
There was a problem hiding this comment.
로그인 성공 시나리오에서 db 조회가 3번 일어나게 됩니다.
한번만 조회해도 좋을 것 같습니다.
|
|
||
| override fun authenticate(accessToken: String): User { | ||
| TODO("Not yet implemented") | ||
| val users = userRepository.findAll().map{User(it.username,it.image)} |
Member
There was a problem hiding this comment.
원래는 findByUsername(accessToken.reversed())를 의도하였습니다., 이 로직은 억지로 들어간 측면이 있긴 합니다.
PFCJeong
force-pushed
the
master
branch
2 times, most recently
from
1a8e813 to
f420cff
Compare
PFCJeong
force-pushed
the
master
branch
3 times, most recently
from
633df04 to
66e14db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.