test(launch): mock default entity for launch CLI tests#11771
Open
nicholaspun-wandb wants to merge 1 commit intomainfrom
Open
test(launch): mock default entity for launch CLI tests#11771nicholaspun-wandb wants to merge 1 commit intomainfrom
nicholaspun-wandb wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
timoffex
reviewed
Apr 22, 2026
Contributor
There was a problem hiding this comment.
Since launch tests are pretty fragile (I find they tend to break due to unrelated refactors), I'm inclined to ask why this change, and whether there is a better way to accomplish this.
Why doesn't InternalApi.default_entity work for these tests? Mocking it could hide a real issue.
Contributor
There was a problem hiding this comment.
I think it is related to #11772? It starts failing recently, so might be related to auth change.
Contributor
There was a problem hiding this comment.
Thanks! If that PR is the fix, then this PR would have hidden a real issue. We should merge that one instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do? Include a concise description of the PR contents.
Testing
How was this PR tested?