Draft
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=3f0fcdfb0bd502fccffab61f420b39256846a7ec |
…erface Remove _flush() from save() to fix CI test hangs caused by double-flushing with TestOnlyFlushingWeaveClient. Add projects_info to TraceServerInterface Protocol to fix mypy attr-defined error. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ClickHouseTraceServer doesn't implement projects_info (it's an external adapter concept). Revert adding it to TraceServerInterface and use type: ignore on the client call instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Since to_json() already runs synchronously (needed for client-side digest computation), there's little benefit in deferring just the obj_create/table_create calls. Making them synchronous avoids excessive _flush() overhead in TestOnlyFlushingWeaveClient which was causing CI test timeouts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add call_processor, get_call_processor, get_feedback_processor to BlockingTraceServer passthrough list so _get_call_processor() properly returns None for SQLite backend (no batch processor) - Add projects_info to expected server call counts - Update test_evaluation_resilience: with synchronous serialization, all 6 server call types (call_start, call_end, obj_create, file_create, table_create, feedback_create) now fail through future_executor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.