chore(weave): Debounced scoring: max sampling rate#6296
Open
mscavezze-cw wants to merge 5 commits intomasterfrom
Open
chore(weave): Debounced scoring: max sampling rate#6296mscavezze-cw wants to merge 5 commits intomasterfrom
mscavezze-cw wants to merge 5 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
mscavezze-cw
changed the title
mscavezze-cw
changed the title
mscavezze-cw
changed the title
gtarpenning
reviewed
Mar 9, 2026
Comment on lines
+50
to
+53
| key = "WF_SCORING_WORKER_DEBOUNCED_SCORING_MAX_SAMPLING_RATE" | ||
| try: | ||
| if key in os.environ: | ||
| del os.environ[key] |
Member
There was a problem hiding this comment.
this could be a test fixture
gtarpenning
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add max sampling rate for debounced scorers. Default to 0.0, meaning that debounced monitors will be ignored.