Add SCP install fallback for remote servers without curl/wget#10215
Merged
alokedesai merged 1 commit intomasterfrom May 6, 2026
Merged
Add SCP install fallback for remote servers without curl/wget#10215alokedesai merged 1 commit intomasterfrom
alokedesai merged 1 commit intomasterfrom
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds curl/wget detection plus an SCP upload fallback for remote server installs on hosts without HTTP clients.
Concerns
- The SCP extraction path is passed as a quoted
$HOME/~value and then moved literally, so the new no-curl/no-wget fallback can fail after uploading the tarball. - The local fallback download is not covered by a timeout, which can leave setup stuck if local
curlstalls.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Member
Author
|
/oz-review |
Contributor
|
I ran into an unexpected error while working on this. You can view the conversation on Warp. Powered by Oz |
moirahuang
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fallback mechanisms for remote server installation:
wgeton the server ifcurlis not installedhttps://www.loom.com/share/7021bd54dbf345c0af595a02eb096a56