Simplify DiffStateModel to have one repo#10283
Merged
MaggieShan merged 3 commits intomasterfrom May 6, 2026
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR simplifies DiffStateModel so each instance is bound to a single repository and moves repository watcher setup into construction.
Concerns
WorkingDirectoriesModel::get_or_create_diff_state_modelnow drops otherwise valid repo paths whenDetectedRepositorieshas not already materialized a watched repository, while callers just return onNone; this regresses the previous fallback detection behavior.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
kevinyang372
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the work needed to support the code review pane and git states on remote environments includes simplifying the contract between the
DiffStateModelandCodeReviewViewDiffStateModelis responsible/associated with only one repoLinked Issue
APP-4353
Testing
Verified existing behaviour for code review view locally
Agent Mode