Update contributing.md and pr template to include manual testing instructions#10286
Update contributing.md and pr template to include manual testing instructions#10286seemeroland merged 5 commits intomasterfrom
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the pull request template and CONTRIBUTING.md to make manual testing expectations more explicit and to move screenshots/videos under the testing section.
Concerns
- The manual testing checkbox should account for changes that cannot be manually tested locally, matching the conditional requirement in the surrounding guidance.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| Manual testing is required for changes that can be manually tested. Include screenshots or screen recordings that show it working end to end if possible. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. | ||
| --> | ||
|
|
||
| - [ ] I have manually tested my changes locally with `./script/run` |
There was a problem hiding this comment.
💡 [SUGGESTION] This checkbox is unconditional, but the surrounding guidance only requires manual testing for changes that can be manually tested; include a non-applicable path so docs-only/template-only PRs don't require a false attestation.
| - [ ] I have manually tested my changes locally with `./script/run` | |
| - [ ] I have manually tested my changes locally with `./script/run`, or this change cannot be manually tested locally |
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
LGTM! Here's hoping the tighter updates to the skill help here.
2 participants
Description
Title