[MacOS] add specialized liquid glass icon especially for dark themes#10287
[MacOS] add specialized liquid glass icon especially for dark themes#10287
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This updates the stable macOS icon assets and Icon Composer configuration for Liquid Glass, including separate light/dark backgrounds and appearance-specific glyph opacity.
Concerns
- No blocking correctness or security concerns found in the annotated diff. The binary image contents are not inspectable from the textual diff, but the PR includes visual evidence for the user-visible icon change.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
alokedesai
left a comment
There was a problem hiding this comment.
I'm down to try it, can you make a call out in slack once this is merged for folks to test out the new icon and see what they think? I'm a little iffy on whether I like it or not
| @@ -1,37 +1,118 @@ | |||
| { | |||
| "fill" : { | |||
There was a problem hiding this comment.
Could you make sure there's a README or some explanation in the codebase for how this icon was made?
Description
This PR updates the MacOS icon to fit with the Liquid Glass style more.
I already got this approved by Peter and Chris.
Linked Issue
This mainly addresses this issue: #8222
The problem we're solving is that the icon doesn't really adapt to the icon style setting in MacOS Tahoe.
Screenshots / Videos
See the 2 icons side-by-side, the current on the left and this new one on the right.
Screen.Recording.2026-05-06.at.11.49.02.AM.mov
Changelog Entries for Stable
CHANGELOG-IMPROVEMENT: [MacOS] New icon to adapt better to "app & widget style" setting in MacOS Tahoe.