Skip to content

[MacOS] add specialized liquid glass icon especially for dark themes#10287

Open
acarl005 wants to merge 3 commits intomasterfrom
andy/mac-glass-icon
Open

[MacOS] add specialized liquid glass icon especially for dark themes#10287
acarl005 wants to merge 3 commits intomasterfrom
andy/mac-glass-icon

Conversation

@acarl005
Copy link
Copy Markdown
Contributor

@acarl005 acarl005 commented May 6, 2026

Description

This PR updates the MacOS icon to fit with the Liquid Glass style more.

I already got this approved by Peter and Chris.

Linked Issue

This mainly addresses this issue: #8222

The problem we're solving is that the icon doesn't really adapt to the icon style setting in MacOS Tahoe.

Screenshots / Videos

See the 2 icons side-by-side, the current on the left and this new one on the right.

Screen.Recording.2026-05-06.at.11.49.02.AM.mov

Changelog Entries for Stable

CHANGELOG-IMPROVEMENT: [MacOS] New icon to adapt better to "app & widget style" setting in MacOS Tahoe.

@acarl005 acarl005 requested a review from alokedesai May 6, 2026 19:01
@cla-bot cla-bot Bot added the cla-signed label May 6, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 6, 2026

@acarl005

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@acarl005 acarl005 changed the title add specialized liquid glass icon especially for dark themes [MacOS] add specialized liquid glass icon especially for dark themes May 6, 2026
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This updates the stable macOS icon assets and Icon Composer configuration for Liquid Glass, including separate light/dark backgrounds and appearance-specific glyph opacity.

Concerns

  • No blocking correctness or security concerns found in the annotated diff. The binary image contents are not inspectable from the textual diff, but the PR includes visual evidence for the user-visible icon change.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Member

@alokedesai alokedesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm down to try it, can you make a call out in slack once this is merged for folks to test out the new icon and see what they think? I'm a little iffy on whether I like it or not

@@ -1,37 +1,118 @@
{
"fill" : {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make sure there's a README or some explanation in the codebase for how this icon was made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants