Remove stray backticks from Windows installer README code blocks#9691
Merged
kevinchevalier merged 1 commit intowarpdotdev:masterfrom May 1, 2026
Conversation
Two `iscc` / `.exe` examples in `script/windows/README.md` ended with a trailing `` `. `` inside their ```shell fences. Inside a code block those characters are literal, so anyone copy-pasting the example into cmd.exe or PowerShell would hit a syntax error. Likely a leftover from when the lines were in prose form (with inline-code backticks closing a sentence) before being wrapped in code fences.
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This docs-only PR removes stray trailing backticks from two Windows installer README shell examples so the commands can be copied without syntax errors.
Concerns
- No correctness, security, or maintainability concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
kevinchevalier
approved these changes
May 1, 2026
Contributor
kevinchevalier
left a comment
kevinchevalier
left a comment
There was a problem hiding this comment.
Thanks for making this change!
captainsafia
added a commit
to warpdotdev/oz-for-oss
that referenced
this pull request
May 1, 2026
…lures in progress comment (#423) ## Problem The review workflow in oz-for-oss fails to actually request team reviews when a `.github/STAKEHOLDERS` entry references a GitHub team (e.g. `@warpdotdev/oss-maintainers`). The bot's progress comment claims the review was requested, but the GitHub API call silently fails because: 1. Team slugs (containing `/`) are passed to the `reviewers` parameter, which only accepts individual user logins. Teams must go through `team_reviewers`. 2. The `GithubException` is caught and logged, but the progress comment is updated unconditionally — always claiming success. Observed on [warpdotdev/warp#9691](warpdotdev/warp#9691 (comment)). ## Changes **`core/workflows/review_pr.py`** - Add `_is_team_slug()` — detects `org/team` format (presence of `/`) - Add `_team_slug_only()` — strips the `org/` prefix for the GitHub API - Add `_split_reviewers()` — partitions a reviewer list into `(user_logins, team_slugs)` - Update `apply_review_result` to: - Split recommended reviewers into users and teams - Pass them to the correct API parameters (`reviewers` vs `team_reviewers`) - Only report successfully requested reviewers in the progress comment **`tests/test_review_pr_reviewer_sampling.py`** - 12 new tests: team slug detection, slug stripping, reviewer splitting, API routing for team vs user, progress comment accuracy on success and on API failure ## Testing All 328 tests pass (including 12 new ones). --- _Conversation: https://staging.warp.dev/conversation/ef40de82-ea29-4fa3-aeab-b5ec896017d9_ _Run: https://oz.staging.warp.dev/runs/019de41d-84ed-77b8-930a-88afee1cc598_ _This PR was generated with [Oz](https://warp.dev/oz)._
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a copy-paste hazard in
script/windows/README.md. Twoiscc/.exeexamples each ended with a trailing`.inside their```shellfenced blocks: