Skip to content

Conversation

lublak
Copy link
Contributor

@lublak lublak commented Jul 29, 2025

No description provided.

@lublak lublak changed the title update to latest s2 update update to latest deps Aug 1, 2025
@lublak
Copy link
Contributor Author

lublak commented Aug 1, 2025

should be good to go, only make docs needs to be called.
I can't currently run this command. But the rest is now up to date @jem-davies @gregfurman

@lublak lublak marked this pull request as ready for review August 1, 2025 12:57
Signed-off-by: Jem Davies <[email protected]>
@lublak
Copy link
Contributor Author

lublak commented Aug 1, 2025

i think i need to fix some more stuff 😞
there are some test issues from parts of the code i didn't touch. Need to look. 👀

@lublak
Copy link
Contributor Author

lublak commented Aug 1, 2025

todo for me!:

  • fix tests for pubsub (comming soon; this weekend) done!
  • update more libs to vX done! (only backoff is not updated from v4 to v5, there are a lot of places, and the api changed, i think it needs another pull request!)

@lublak lublak marked this pull request as draft August 3, 2025 19:01
@lublak
Copy link
Contributor Author

lublak commented Aug 3, 2025

Soooo back to pubsub/v2 topic is now called publisher. Should we keep "topic" in the config?
Also:There is no more Topic/Publisher .Exists I currently "Get the topic" to check if it exists. But the same check could be und "Message send". So it could be improve API usage and performance. But! Also a big breaking change: not erroring before sending.

@lublak lublak marked this pull request as ready for review August 3, 2025 20:16
@lublak
Copy link
Contributor Author

lublak commented Aug 3, 2025

breaking changes:

  • sync for pub sub is not available any more
  • awk "{ }" now not changes any data

@jem-davies
Copy link
Collaborator

Hey thanks for taking the time to get this PR together.

I think that it would be much more easier to review if it was broken down into separate PRs; ideally for each dependency that has been upgraded across major versions. That way we can more easily see what changes to the code are required for each dependency update. For those changes that have minimal impact - we can easily merge - and the ones that do have impacts we can discuss individually; what are the specific needs for the upgrade etc.

Would you be willing to break this into separate PRs?

@lublak
Copy link
Contributor Author

lublak commented Aug 13, 2025

Would you be willing to break this into separate PRs?

Yeah. It's very to have to take it apart, but I can do it. Takes some time, i'm currently on holiday

@jem-davies
Copy link
Collaborator

Ok great! thanks so much for the effort again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants