-
Notifications
You must be signed in to change notification settings - Fork 144
update to latest deps #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
should be good to go, only |
Signed-off-by: Jem Davies <[email protected]>
i think i need to fix some more stuff 😞 |
todo for me!:
|
Soooo back to pubsub/v2 topic is now called publisher. Should we keep "topic" in the config? |
breaking changes:
|
Hey thanks for taking the time to get this PR together. I think that it would be much more easier to review if it was broken down into separate PRs; ideally for each dependency that has been upgraded across major versions. That way we can more easily see what changes to the code are required for each dependency update. For those changes that have minimal impact - we can easily merge - and the ones that do have impacts we can discuss individually; what are the specific needs for the upgrade etc. Would you be willing to break this into separate PRs? |
Yeah. It's very to have to take it apart, but I can do it. Takes some time, i'm currently on holiday |
Ok great! thanks so much for the effort again |
No description provided.