Skip to content

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Sep 2, 2025

This will likely simplify integration of #1650.

@Robbepop Robbepop force-pushed the rf-rename-instruction-to-op branch from 94ce731 to a614fdf Compare September 2, 2025 13:54
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 58.68393% with 383 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.77%. Comparing base (f7c77a7) to head (0e7d442).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/translator/func/visit.rs 43.12% 182 Missing ⚠️
crates/wasmi/src/engine/translator/comparator.rs 37.72% 170 Missing ⚠️
crates/wasmi/src/engine/translator/func/mod.rs 84.00% 12 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/simd.rs 14.28% 6 Missing ⚠️
crates/wasmi/src/engine/translator/func/simd/op.rs 0.00% 6 Missing ⚠️
...rates/wasmi/src/engine/translator/func/simd/mod.rs 70.00% 3 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/copy.rs 75.00% 1 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/return_.rs 75.00% 1 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/store.rs 0.00% 1 Missing ⚠️
crates/wasmi/src/engine/translator/utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
+ Coverage   70.65%   70.77%   +0.11%     
==========================================
  Files         179      179              
  Lines       15243    15199      -44     
==========================================
- Hits        10770    10757      -13     
+ Misses       4473     4442      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop changed the title Rename Instruction -> Op Rename wasmi_ir::Instruction -> Op Sep 2, 2025
@Robbepop Robbepop merged commit 5bc0de6 into main Sep 2, 2025
18 of 19 checks passed
@Robbepop Robbepop deleted the rf-rename-instruction-to-op branch September 2, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant