Skip to content

Fix hydration#654

Merged
cprecioso merged 2 commits intomainfrom
cprecioso/fix-hydration
Mar 31, 2026
Merged

Fix hydration#654
cprecioso merged 2 commits intomainfrom
cprecioso/fix-hydration

Conversation

@cprecioso
Copy link
Copy Markdown
Member

@cprecioso cprecioso commented Mar 30, 2026

According to facebook/react#36169, we'll need to migrate to async scripts instead of defer

@cprecioso cprecioso self-assigned this Mar 30, 2026
@cprecioso cprecioso marked this pull request as ready for review March 30, 2026 15:36
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 30, 2026

Confidence Score: 5/5

Safe to merge — minimal, targeted fix with no risk of regression

The change is a two-attribute swap (deferasync) on third-party analytics script tags. Both attributes are well-understood browser primitives: async is semantically correct for independent analytics scripts that have no ordering constraints and don't depend on DOM readiness. The vite-ignore='' cleanup in the diff file removes an attribute that was never a real Vite directive (the valid Vite attribute is data-vite-ignore), so its removal is a harmless improvement. No application logic is affected.

No files require special attention

Important Files Changed

Filename Overview
template/app/main.wasp Changes Plausible analytics script loading attribute from defer to async to fix React hydration issues
opensaas-sh/app_diff/main.wasp.diff Updates the opensaas.sh-specific diff to match: deferasync and removes the non-standard vite-ignore='' attribute from the Plausible script tag

Reviews (1): Last reviewed commit: "Merge branch 'main' into cprecioso/fix-h..." | Re-trigger Greptile

@cprecioso cprecioso requested a review from infomiho March 30, 2026 15:54
@cprecioso cprecioso merged commit b3ace22 into main Mar 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant