Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Feature/login#33

Merged
EstebanDalelR merged 27 commits intodevfrom
feature/login
Sep 15, 2023
Merged

Feature/login#33
EstebanDalelR merged 27 commits intodevfrom
feature/login

Conversation

@EstebanDalelR
Copy link
Copy Markdown
Member

Description

Allows logging in to watermelon and storing the credentials for later use

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Acceptance

@watermelon-copilot-for-code-review
Copy link
Copy Markdown

watermelon-copilot-for-code-review Bot commented Sep 7, 2023

WatermelonAI Summary

The 27 commits in this PR are focused on implementing a new feature for logging in to Watermelon and storing the credentials for later use. The commits include fixes to the root project, adding button group and login buttons, taking user token and email as input, making requests to the API, storing data when logged in, hiding the login button if already logged in, code improvements, creating a data extractor, changing data types, displaying all data from context, using an expandable panel, code reorganization, updating ignore file, allowing hiding and showing of information, allowing multiline body, adding a commits panel and removing warnings, making UI enhancements like making the body a button and scrollable, extracting listeners and backend URLs, and changing input types. Overall, the commits show iterative progress and improvements to enable a smooth login experience.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Slack Threads deactivated by EstebanDalelR
Notion Pages deactivated by EstebanDalelR
Linear Tickets deactivated by EstebanDalelR
Click here to login to Asana
watermelon-intellij is an open repo and Watermelon will serve it for free.
🍉🫶

Copy link
Copy Markdown
Contributor

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand rendering information on the Tool Window Factory will depend on logging in (action which LGTM). If this is the case:

  1. I'd like us to re-test after we merge the backend changes
  2. The Tool Window Factory should show a text that invites to log in .

@EstebanDalelR EstebanDalelR changed the base branch from main to dev September 14, 2023 14:38
Comment thread src/main/kotlin/com/watermelon/context/actions/LoginAction.kt Outdated
Copy link
Copy Markdown
Contributor

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to

  • Change the user email prompt from a password dialog to an input dialog
  • Solve the 404 issue

@EstebanDalelR
Copy link
Copy Markdown
Member Author

We need to

* Change the user email prompt from a password dialog to an input dialog

* Solve the 404 issue

I changed the input.
The 404 can't be reproduced, not in localhost or prod version of the backend

@EstebanDalelR EstebanDalelR merged commit ff63e3c into dev Sep 15, 2023
@baristaGeek
Copy link
Copy Markdown
Contributor

We need to

* Change the user email prompt from a password dialog to an input dialog

* Solve the 404 issue

I changed the input. The 404 can't be reproduced, not in localhost or prod version of the backend

Ok LGMT then. I'll assume it's something with my local env.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants