[codex] fix(simple): cooperatively cancel specprefill workers#280
Draft
Thump604 wants to merge 2 commits intowaybarrios:mainfrom
Draft
[codex] fix(simple): cooperatively cancel specprefill workers#280Thump604 wants to merge 2 commits intowaybarrios:mainfrom
Thump604 wants to merge 2 commits intowaybarrios:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancel_checkhook through_prefill_draft,score_tokens, andsparse_prefillmaindecode shapeWhy
_run_blocking_serialized()now keeps the async generation lock held until the worker thread actually finishes, but long-running SpecPrefill phases still need a cooperative exit path after request cancellation. Without that, cancelled SpecPrefill requests can keep burning CPU inside blocking scoring/prefill loops even though the request is already gone.Validation
black --fast --check vllm_mlx/engine/simple.py vllm_mlx/specprefill.py tests/test_simple_engine.pypytest -q tests/test_simple_engine.py