Open
Conversation
In PR 276 it was observed the lower bound of torch was lower than pip would resolve it do. Since vllm-mlx advertises it should be run with python 3.10+, I upgraded the libraries as far as possible without compile errors. Attempting to upgrade torch to 2.9 and torchvision to 0.24 let to dependency resolution errors so I went with the python 3.9 compatible versions listed on https://pypi.org/project/torchvision/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR 276 it was observed the lower bound of torch was lower than pip would resolve it to. Since vllm-mlx advertises it should be run with python 3.10+, I upgraded the libraries as far as possible without compile errors. Attempting to upgrade torch to 2.9 and torchvision to 0.24, which are python 3.10+ led to dependency resolution errors so I went with the python 3.9 compatible versions listed on https://pypi.org/project/torchvision/ torch to 2.8 and torchvision to 0.21