Compare RHEL version as integer when having custom packages#1946
Open
araujorm wants to merge 1 commit intowazuh:4.14.4from
Open
Compare RHEL version as integer when having custom packages#1946araujorm wants to merge 1 commit intowazuh:4.14.4from
araujorm wants to merge 1 commit intowazuh:4.14.4from
Conversation
Fixes yum module being used instead of dnf on RHEL and clones >= 10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes yum module being used instead of dnf on RHEL and clones >= 10. Otherwise, as the comparison is made as a string, "10" is always < "8" (and not the expected 10 >= 8).
Despite this, without this fix the playbook still works when the RHEL 10 installation has the appropriate yum wrapper installed, but it's not the best approach to mandate that, and on minimal installs that may not always be the case so the playbook shouldn't depend on it.