Add optional old value in replace operation#70
Open
mariotoffia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @wbish,
When
OperationTypes.Replaceit will capture the replace value and add it to the operation. The old property is only JSON visible when not null. Hence, the following output can be achieved:The diff:
{"building":{"loc":{"provision":["2023-12-18T15:08:26Z","2024-02-01T16:00:00Z"]}}}The json delta formatter:
[{"path":"/building/loc/provision","op":"replace","value":"2024-02-01T16:00:00Z","old":"2023-12-18T15:08:26Z"}]I'm on a Mac and do not have mono, so sorry for not providing any unit test - I've used it in my other project code and it seems to work properly.
I hope, this is a valid contribution. Please tell me otherwise and I'll fix it.
Cheers,
Mario :)