Fix/labels not showing in tasks list #575
Conversation
WalkthroughThe pull request adds Node.js version pinning, updates settings controller to properly include project IDs in data persistence, and fixes DOM structure inconsistencies in Vue task list components by relocating action elements and correcting template syntax. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@views/assets/src/components/project-task-lists/completed-tasks.vue`:
- Around line 36-39: The template in completed-tasks.vue is using the
globally-registered <pm-do-action> while the sibling incompleted-tasks.vue uses
a locally imported <do-action>; make them consistent by replacing <pm-do-action
:hook="'completed-task_inline'" :actionData="doActionData"> with the
locally-registered <do-action> and add the same local import and components
registration used in incompleted-tasks.vue (e.g., import DoAction from
'.../do-action.vue' and include DoAction in the components object), preserving
the existing props (doActionData and hook) so the prop names and usage remain
identical to incompleted-tasks.vue.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonviews/assets/vendor/vue-fullscreen/vue-fullscreen.min.jsis excluded by!**/*.min.js
📒 Files selected for processing (4)
.nvmrcsrc/Settings/Controllers/Settings_Controller.phpviews/assets/src/components/project-task-lists/completed-tasks.vueviews/assets/src/components/project-task-lists/incompleted-tasks.vue
🔇 Additional comments (5)
.nvmrc (1)
1-1: LGTM!Pinning Node.js to version 18 (LTS) ensures consistent development environments across the team.
views/assets/src/components/project-task-lists/completed-tasks.vue (1)
88-93: LGTM!The
doActionDatacomputed property correctly provides the task and list context needed for the action hook to render labels.src/Settings/Controllers/Settings_Controller.php (1)
100-106: Good fix for data integrity.This ensures
project_idis included in the data passed toupdate_model(), which is essential for correctly persisting project-scoped settings like labels. Without this, theproject_idassociation could be lost during updates.views/assets/src/components/project-task-lists/incompleted-tasks.vue (2)
40-46: LGTM!The DOM structure is correct with the
do-actioncomponent properly nested insidediv.task-activity. The commented-out anchor block is cleanly terminated.
223-228: LGTM!The
doActionDatacomputed property correctly provides the task and list context. The added semicolon improves code consistency.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| </a> --> | ||
| <div class="task-activity"> | ||
| <pm-do-action :hook="'completed-task_inline'" :actionData="doActionData"></pm-do-action> | ||
| </div> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
echo "=== Searching for pm-do-action usage ==="
rg -n "pm-do-action" -A 2 -B 2 --type vue --type js
echo -e "\n=== Searching for do-action usage in Vue files ==="
rg -n "<do-action" -A 2 -B 2 --type vue
echo -e "\n=== Checking completed-tasks.vue for component imports/usage ==="
fd "completed-tasks.vue" --type f
echo -e "\n=== Checking incompleted-tasks.vue for component imports/usage ==="
fd "incompleted-tasks.vue" --type fRepository: weDevsOfficial/wp-project-manager
Length of output: 581
🏁 Script executed:
echo "=== Searching for pm-do-action ==="
rg "pm-do-action"
echo -e "\n=== Searching for <do-action ==="
rg "<do-action"
echo -e "\n=== Reading completed-tasks.vue (around the specified lines) ==="
sed -n '30,50p' views/assets/src/components/project-task-lists/completed-tasks.vue
echo -e "\n=== Reading incompleted-tasks.vue to check do-action usage ==="
rg -B 2 -A 2 "do-action" views/assets/src/components/project-task-lists/incompleted-tasks.vueRepository: weDevsOfficial/wp-project-manager
Length of output: 6698
Component inconsistency needs resolution.
This file uses the globally registered <pm-do-action> component while the sibling incompleted-tasks.vue in the same directory uses the locally imported <do-action> component. Since both files handle similar task display logic (completed vs incompleted tasks), they should use the same component. Update one file to match the other for consistency.
🤖 Prompt for AI Agents
In `@views/assets/src/components/project-task-lists/completed-tasks.vue` around
lines 36 - 39, The template in completed-tasks.vue is using the
globally-registered <pm-do-action> while the sibling incompleted-tasks.vue uses
a locally imported <do-action>; make them consistent by replacing <pm-do-action
:hook="'completed-task_inline'" :actionData="doActionData"> with the
locally-registered <do-action> and add the same local import and components
registration used in incompleted-tasks.vue (e.g., import DoAction from
'.../do-action.vue' and include DoAction in the components object), preserving
the existing props (doActionData and hook) so the prop names and usage remain
identical to incompleted-tasks.vue.
1 participant
fix #275
related enhancement #279
Issue description:
After creating labels and assigning them to the tasks, they are not visible from the task list.
Steps to reproduce:
Navigate to Project Manager >> Projects >> Task lists >> Task >> add labels.
Aside task list, labels are not visible
Summary by CodeRabbit
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.