Show warning when card requires activation #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metsma
force-pushed
the
locked
branch
10 times, most recently
from
7e98904 to
7df05b8
Compare
metsma
force-pushed
the
locked
branch
3 times, most recently
from
459def8 to
4e5b861
Compare
mrts
reviewed
Oct 10, 2025
metsma
force-pushed
the
locked
branch
8 times, most recently
from
c4e19fb to
1b6849c
Compare
WE2-1114, WE2-1119 Signed-off-by: Raul Metsma <[email protected]>
mrts
approved these changes
Oct 16, 2025
|
|
||
| // http://www.etsi.org/deliver/etsi_en/319400_319499/31941201/01.01.01_60/en_31941201v010101p.pdf | ||
| if (serialNumber.size() > 6 && serialNumber.startsWith(QStringLiteral("PNO")) | ||
| if (serialNumber.size() > 6 && serialNumber.startsWith(QLatin1String("PNO")) |
There was a problem hiding this comment.
Is there any reason not to use the QString operator:
Suggested change
| if (serialNumber.size() > 6 && serialNumber.startsWith(QLatin1String("PNO")) | |
| if (serialNumber.size() > 6 && serialNumber.startsWith(u"PNO"_s)) |
There was a problem hiding this comment.
We need still support Qt 6.2
There was a problem hiding this comment.
We need still support Qt 6.2.
https://doc.qt.io/qt-6/qt-literals-stringliterals.html Since 6.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raul Metsma [email protected]