Skip to content

Feat/custom rpc url #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat/custom rpc url #93

wants to merge 3 commits into from

Conversation

@taylorjdawson
Copy link
Contributor

No description provided.

@taylorjdawson
Copy link
Contributor Author

taylorjdawson commented Apr 25, 2020 •
edited
Loading

@TrevorJTClarke Looks like the linter got a lot more opinionated...I like it!

Also I saw rpc tests were turned off, can those be turned back on?

@TrevorJTClarke
Copy link
Contributor

@taylorjdawson couple things:

  1. Can you bump the version on this?
  2. merge latest master in
  3. I had to turn off RPC tests because the logic was using subjective cases, meaning in some cases mempool address didnt have any txns so it would fail simply because live data didnt exist. These tests need another pass to be more generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taylorjdawson @TrevorJTClarke