Update library name #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli Ma <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Buck2 target name for the main library from git_internal to git-internal to align with Buck2 naming conventions that prefer hyphens for target names. This change makes the target name consistent with other Buck2 targets in the repository such as git-internal-vendor and git-internal-manifest.
- Updated Buck2
rust_librarytarget name to use hyphens instead of underscores - Updated CI workflow to reference the new target name
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| BUCK | Updated the rust_library target name from git_internal to git-internal to follow Buck2 naming conventions |
| .github/workflows/base.yml | Updated Buck2 build command to reference the renamed target git-internal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.