Fix custom callback#20
Open
azatoth wants to merge 2 commits into
Open
Conversation
We need to check scope.$parent for the inputNameSetArgs callback Closes webadvanced#14
|
When can we expect this to be merged? |
Contributor
|
When there is a test suite to cover the module. I will have time to write one next month or someone in the community is welcome to write one. With all the features there is now no way to manually regression test this module without tests. |
|
Yep... it should have $parent after scope... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per issue #14 make the implementation to go via $parent