Conversation
Collaborator
Author
Contributor
|
Please update the readme with the changes |
Collaborator
Author
|
@skalero01 Recuerdo que sigue el PR |
Contributor
|
ya movmimos v3 a master, por lo que hay muchos conflictos, puedes solucionarlos? y ya los mergeo @LuanHimmlisch |
Collaborator
Author
|
@skalero01 perfecto, checo los conflictos entonces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This PR is meant to refactor the code relating to the state of the Front actions taken by the user, also known as the
sourcetype. Previously, this source was managed as a simplestringthat prevents Intellisense from working, and allows human error.This PR does the following to fix the mentioned errors:
WeblaborMx\Front\Sourceclass, that is meant to be used as anEnumcompatible with PHP 7.1.isForm(),isServerSide()andisClientSide().session()out of theSourceabletrait, in order to reuse it inside theInputclass.SourceclassStringableso it can be cast tostringand used as it was.$sourcevariable as@deprecatedto prevent the usage.With this PR, the value of the source is always known, through enumeration, validation and IDE autocompletion.