chore: upgrade eslint from v8 to v9 #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 82.26% 72.99% -9.28%
==========================================
Files 4 4
Lines 141 137 -4
Branches 51 51
==========================================
- Hits 116 100 -16
- Misses 16 24 +8
- Partials 9 13 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/runtime/getGlobalThis.js
Outdated
| if (typeof window === "object") { | ||
| return window; | ||
| if (typeof globalThis.window === "object") { | ||
| return globalThis; |
There was a problem hiding this comment.
In this place lets keep window for tests, just use // eslint-disable-next-line
src/runtime/getGlobalThis.js
Outdated
| } | ||
|
|
||
| return g; | ||
| return globalObj; |
There was a problem hiding this comment.
This is a breaking change, we should keep logic without globalThis, because it will not work in old browsers
alexander-akait
requested changes
Jul 28, 2025
|
@alexander-akait done |
| // This works if eval is allowed (see CSP) | ||
| // eslint-disable-next-line no-new-func | ||
| g = this || new Function("return this")(); | ||
| } catch (e) { |
There was a problem hiding this comment.
Keep e because old browsers doesn't support optional catch
alexander-akait
approved these changes
Jul 29, 2025
alexander-akait
merged commit 3ebac92
into
webpack-contrib:master
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
upgrade eslint from v8 to v9
Breaking Changes
No
Additional Info
No