Submissions #2
Open
Submissions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Test Plan checklist
…with overloaded new/delete Make 'Testing:' label target match Test Plan Checklist
… to this particular class.
…klist Shortened some multilined template names Note: some cases are effectively noops (eg. case 5 and case 10) I see multiple ways of representing 'const references' in the Test Plan 1 const_references 2 const T& it seems we should standardize how this is done.
…an Checklist replace all 'const_reference' instance with 'const T&' update const T& operator[](size_type pos) const to be fully checked in test case 15 not 4 There is a strange 2 line checklist item that seems unused // [20] template <class Args...> // iterator emplace(const_iterator pos, Args...);
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed vector.t.cpp. Ready to be collected for submission to bloomberg.