Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds conditional icon rendering to specific accessibility-related headings on the accessibility pages. When certain heading text matches predefined strings (case-insensitive), corresponding accessibility icons are displayed inline with the heading text.
Key changes:
- Added
pageUidto theSliceZoneContextto identify which page is being rendered - Modified the Text slice component to conditionally use a new
accessibilitySerializerfor accessibility pages - Created
accessibilitySerializerthat matches heading text and renders appropriate icons (BSL, wheelchair access, audio description, and induction loop)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| content/webapp/views/components/Body/index.tsx | Added pageUid field to SliceZoneContext type and default context to enable page-specific rendering logic |
| common/views/slices/Text/index.tsx | Added conditional logic to use accessibilitySerializer when rendering text on accessibility pages |
| common/views/components/HTMLSerializers/index.tsx | Implemented new accessibilitySerializer that matches heading text and renders icons alongside headings for accessibility features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rcantin-w
reviewed
Jan 9, 2026
Contributor
rcantin-w
left a comment
rcantin-w
left a comment
There was a problem hiding this comment.
Behaves well in all browsers and on smaller screens; with and without toggle
Contributor
|
Do we care about adding a test for this? Could flag when there's an issue? 🤔 |
rcantin-w
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
For #12603
Conditional adds icons for certain headings on the accessibility page:
Added exact text matching (case-insensitive) for:
"BSL" → BSL square icon
"Wheelchair and physical access" → Accessible icon
"Audio description" → Audio described icon
"Induction loops" → Induction loop icon
How to test
How can we measure success?
People can quickly find the section they are interested in
Have we considered potential risks?
None really