fix(filter-control): wire up hideUnusedSelectOptions for hide-unused-select-options#8376
Open
sawirricardo wants to merge 1 commit into
Open
fix(filter-control): wire up hideUnusedSelectOptions for hide-unused-select-options#8376sawirricardo wants to merge 1 commit into
sawirricardo wants to merge 1 commit into
Conversation
…used-select-options The hideUnusedSelectOptions function was defined but never called, making the data-hide-unused-select-options attribute non-functional. - Add filterControlHideUnusedSelectOptions option to defaults - Call hideUnusedSelectOptions in initFilterSelectControls when enabled Fixes wenzhixin#7719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
hideUnusedSelectOptionsfunction insrc/extensions/filter-control/utils.jswas defined and exported but never called anywhere, making thedata-hide-unused-select-optionsattribute completely non-functional.Reported in #7719 — the feature last worked in v1.19.1.
Changes
filterControlHideUnusedSelectOptions: falseto the filter-control default optionshideUnusedSelectOptions(selectControl, uniqueValues)ininitFilterSelectControlswhen the option is enabledExample
Fixes #7719