Refactor lz4 override to shared package#15
Conversation
- Created `pkgs/lz4.nix` which overrides lz4 to include the `lz4c` symlink. - Added `lz4` to `pkgs/default.nix`. - Replaced the inline override in `hosts/omnius/default.nix` with `pkgs.myPkgs.lz4`. This change prevents redundant builds by sharing the derivation and centralizing the package definition. Co-authored-by: whitestrake <9500326+whitestrake@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR refactors the inline
lz4override found inhosts/omnius/default.nixinto a standalone package definition inpkgs/lz4.nix.Changes
postInstalllogic that creates thelz4csymlink is now inpkgs/lz4.nix.pkgs/default.nixaslz4(accessible viamyPkgs.lz4).hosts/omnius/default.nixnow uses the shared package instead of an inline override.Benefits
pkgs/.PR created automatically by Jules for task 16296258148251996757 started by @whitestrake