Skip to content

feat: restore session check on landing page#95

Merged
will-lp1 merged 1 commit intomainfrom
codex/add-session-check-to-landing-page
Sep 3, 2025
Merged

feat: restore session check on landing page#95
will-lp1 merged 1 commit intomainfrom
codex/add-session-check-to-landing-page

Conversation

@will-lp1
Copy link
Owner

@will-lp1 will-lp1 commented Sep 3, 2025

Summary

  • derive landing page session state with authClient.useSession
  • ensure "Open" CTA displays when a session exists

Testing

  • pnpm --filter @saru/app lint
  • pnpm test (fails: No tests found)

https://chatgpt.com/codex/tasks/task_e_68b82c06d39c8325abb207de90f87da4

Summary by CodeRabbit

  • Bug Fixes

    • Fixed occasional delays and inconsistencies in detecting login status.
    • Improved redirect behavior after sign-in/sign-out for a smoother flow.
  • Refactor

    • Streamlined session handling to react instantly to authentication changes, reducing UI latency.
    • No changes to visible page content or actions beyond more reliable session-aware behavior.

@vercel
Copy link

vercel bot commented Sep 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cursorforwriting-wkur Error Error Sep 3, 2025 0:02am

@coderabbitai
Copy link

coderabbitai bot commented Sep 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Replaced manual session state/effect with authClient.useSession(), deriving hasSession from the hook. Removed the useEffect-based getSession() call and related error handling. Existing logic (star count fetch, header/CTA) now consumes the derived hasSession. No exported/public API changes.

Changes

Cohort / File(s) Summary
Session handling refactor
apps/saru/app/page.tsx
Removed local hasSession state and useEffect that called authClient.getSession(); now uses authClient.useSession() and derives hasSession as !!session?.user. Component reactivity to session updates is implicit; other logic remains unchanged aside from using the new hasSession source.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant PageComponent as Page Component
  participant AuthClient as authClient
  participant GitHubAPI as Star Count API

  rect rgb(240,248,255)
    note over PageComponent: Render
    PageComponent->>AuthClient: useSession()
    AuthClient-->>PageComponent: session (reactive)
    alt session.user exists
      PageComponent->>PageComponent: hasSession = true
      PageComponent->>GitHubAPI: fetch star count
      GitHubAPI-->>PageComponent: star count
    else no session
      PageComponent->>PageComponent: hasSession = false
      note right of PageComponent: Gate CTA / routing based on hasSession
    end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitched my nose at state’s old dance,
Now hooks hum tunes of happenstance.
Session drifts in—no polling fuss,
Reactivity rides the bus.
Stars still sparkle, routes stay clean—
A tidy warren, swift and keen. 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1a3d82a and db35412.

📒 Files selected for processing (1)
  • apps/saru/app/page.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/add-session-check-to-landing-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@will-lp1 will-lp1 merged commit 65b4523 into main Sep 3, 2025
2 of 4 checks passed
@will-lp1 will-lp1 deleted the codex/add-session-check-to-landing-page branch October 24, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant