Add comprehensive test suite: 348 tests, 98%+ coverage, CI#2
Merged
williamhallpreston merged 8 commits intomainfrom Apr 5, 2026
Merged
Add comprehensive test suite: 348 tests, 98%+ coverage, CI#2williamhallpreston merged 8 commits intomainfrom
williamhallpreston merged 8 commits intomainfrom
Conversation
File was committed before node_modules/ was added to .gitignore. https://claude.ai/code/session_01LRY5gr1pj5keTZMrqufwgX
Completes Priority 1 coverage of quantum-engine.js: - _tunnelingProbability: ground-state zero, energy scaling, planckScale proportionality, peaked vs flat superposition comparison - _applyTunneling: valid pitch output, level clamping at boundaries [0,11], onTunnel callback signature, null-callback safety, setTimeout scheduling https://claude.ai/code/session_01LRY5gr1pj5keTZMrqufwgX
Extract four pure functions from the server startup block so they can
be unit tested without binding real sockets:
- forwardOscMessage: dispatches to Ableton (9000) and TouchDesigner (7001)
- isNotableAddress: identifies collapse/tunnel addresses for logging
- relayOscToClients: broadcasts inbound OSC to all open WS clients
- buildWelcomeMessage: constructs the browser handshake payload
Add 35 new Jest tests covering:
- forwardOscMessage: correct hosts/ports, always sends to both, independent
error handling per destination
- isNotableAddress: all 7 known addresses, collapse and tunnel flagged
- relayOscToClients: single/multi-client broadcast, OPEN-state filtering,
empty set, JSON envelope shape, identical payload across clients
- buildWelcomeMessage: valid JSON, type field, port values, no internal
ports leaked
https://claude.ai/code/session_01LRY5gr1pj5keTZMrqufwgX
Export AudioEngine via CommonJS for Node.js test environments.
Add 39 Jest tests with a full Web Audio API mock (AudioContext,
GainNode, OscillatorNode, BiquadFilterNode, StereoPannerNode,
ConvolverNode) covering:
- initialize(): idempotency, AudioContext creation, masterGain/
reverbGain defaults, convolver setup, destination connection
- playNote(): no-op when uninitialized, voice storage, MIDI→Hz
conversion (A3/A4/A5), spin→pan, coherence→filter frequency,
probabilities array for partial amplitudes, 1/(k+1) fallback,
partial count scaling with coherence (2–6), harmonic series,
stopNote-before-replay, attack gain ramp scheduling
- stopNote(): missing-voice safety, voice removal, gain cancellation,
exponential release ramp, default (0.6s) and custom release times
- setMasterVolume() / setReverbMix(): settings + live gain node update,
safe before initialization
- resume(): calls ctx.resume() when suspended, skips when running,
safe before initialization
https://claude.ai/code/session_01LRY5gr1pj5keTZMrqufwgX
… leaks
Implement OSCClient (osc-client.js):
- connect() opens a WebSocket to the bridge
- _send() silently no-ops when disconnected
- sendNote: normalizes velocity to 0-1, sends to /eigenstate/note
- sendCollapse, sendWaveform, sendEntangle, sendTunnel, sendDecohere,
sendSpin, sendEnergy: correct OSC addresses and arg ordering
- sendStateSnapshot: one decohere + optional waveform per voice
Implement MIDIBridge (midi-bridge.js):
- initialize(): uses navigator.requestMIDIAccess, returns bool
- noteOn/noteOff: 0x90/0x80 status with 7-bit masking
- sendProbability: CC 1 (mod wheel), 0-1 → 0-127
- sendCoherence/sendDecoherence: CC 91 (reverb), inverted
- sendSpin: CC 10 (pan), -1-1 → 0-127
- sendEnergyLevel: CC 74 (filter), -4-4 → 0-127, clamped
- sendTunnelingBend: 14-bit pitch bend from semitone delta
- allNotesOff: CC 123
- getOutputName: device name or "Not connected"
Both files gain CommonJS exports for testing.
Add 66 Jest tests in tests/stubs.test.js.
Fix timer leak warnings: add jest.clearAllTimers() to all QuantumEngine
and AudioEngine.stopNote() afterEach hooks so the _startUpdateLoop
setInterval and stopNote setTimeout don't outlive their test suites.
https://claude.ai/code/session_01LRY5gr1pj5keTZMrqufwgX
Add 18 tests targeting the five previously uncovered code paths:
collapse() fallback (line 84):
- Denormalized state with Math.random mocked above prob sum triggers
the safety return of numStates-1
_reExpandState (lines 320-326):
- Missing voice no-op, collapsed flag reset, collapsedState reset,
re-normalization, birthTime refresh, centering on collapsedState
measureVoice tunneling branch (line 260):
- Mock _tunnelingProbability to 1.0 and Math.random to 0 to force
the tunneling code path; verify onTunnel fires and pitch is valid
_applyTunneling setTimeout callback (lines 302-303):
- Advance fake timers 50ms to execute re-expansion; verify voice
re-normalizes; verify missing voice does not crash
_startUpdateLoop interval callback (lines 390-413):
- Advance fake timers 16ms to execute one tick
- onDecohere fires for uncollapsed voices, skips collapsed ones
- onWaveformUpdate fires with Float32Array waveforms for all voices
- timeEvolve called once per tick per voice
- Auto-collapse triggers when applyDecoherence returns >0.99
- Re-expansion setTimeout fires 500ms after auto-collapse
- Empty voices map produces onWaveformUpdate({}) without crashing
https://claude.ai/code/session_01LRY5gr1pj5keTZMrqufwgX
GitHub Actions (.github/workflows/test.yml):
- js job: Node 20, npm ci, jest --coverage
- python job: Python 3.11, pip install pytest, pytest
Runs on every push and pull request.
Coverage (package.json):
- Add osc-client.js and midi-bridge.js to collectCoverageFrom
- Add coverageThreshold: 85% statements/lines globally,
95% statements/lines for quantum-engine.js
- Mark bridge.js server startup block with istanbul ignore next
so the intentionally-untestable socket-binding code does not
count against global thresholds (bridge pure functions: 100%)
Bug fix (src/osc-client.js):
- connect() previously called require('ws') when
typeof WebSocket === 'undefined', which would throw a
ReferenceError in any browser environment where require is
also absent; fix to guard with typeof require !== 'undefined'
Tests (tests/stubs.test.js):
- Replace untestable "null WS" scenario with practical Node.js
fallback test and five connect() handler tests covering the
global.WebSocket path, onopen/onclose wiring, and the
require('ws') fallback path
README.md: add Testing section with npm and pytest commands
Final coverage: 97.18% statements / 88.69% branches / 96.51% functions
https://claude.ai/code/session_01LRY5gr1pj5keTZMrqufwgX
audio-engine.js:
- webkitAudioContext fallback: test initialize() with only
window.webkitAudioContext set (no AudioContext), covers line 13 branch
- stopNote setTimeout callback: advance fake timers 700ms to fire the
oscillator-stop loop; covers both anonymous functions at line 88
- Swallowed osc.stop() error: mock osc.stop to throw and confirm
the try/catch silently absorbs it
quantum-engine.js:
- applyDecoherence zero-norm guard: set all amplitudes to zero before
calling, confirms the if(norm>0) false path does not NaN-corrupt state
- sampleWaveFunction default arg: call with no argument, confirm output
equals explicit 'harmonic' call, covers default-arg branch at line 116
- entangle default correlationStrength: call entangle(a,b) without third
arg, confirm stored value is 0.8, covers default-arg at line 330
- _propagateEntanglement skip path: mock Math.random to return 0.9
with correlation 0.3, confirm partner amplitudes unchanged,
covers if(Math.random()<correlation) false branch at line 350
- measureVoice re-expansion callback: advance timers 100ms after
measureVoice, confirm voice collapses then re-expands into normalized
superposition, covers anonymous function at line 274
Final: 98.12% statements / 92.26% branches / 100% functions
Remaining uncovered: browser window.X = X else-branches (untestable in Node)
https://claude.ai/code/session_01LRY5gr1pj5keTZMrqufwgX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a full test suite to the previously untested codebase, implements the two stub classes (
OSCClient,MIDIBridge), adds GitHub Actions CI, and fixes a browser crash bug found during the process.348 tests total — 276 JavaScript (Jest) + 72 Python (pytest)
Test coverage
src/quantum-engine.jssrc/audio-engine.jssrc/osc-client.jssrc/midi-bridge.jsosc/bridge.jsRemaining uncovered branches are
window.X = Xbrowser-global assignments inelseblocks — untestable in Node.js by design.What was added
JavaScript tests (
tests/)quantum-engine.test.js(133 tests) —QuantumStateandQuantumEngine: probability math, wave function collapse (statistical bias, idempotency, denormalized fallback), time evolution (unitarity), decoherence, Hermite polynomials, hydrogen basis functions, pitch mapping, entanglement propagation, tunneling probability + clamping,_reExpandState,measureVoicetunneling branch and re-expansion callback,_startUpdateLoopinterval (decohere/waveform callbacks, auto-collapse at decoherence > 0.99)bridge.test.js(140 tests) — pure helper functions:normalizeOscArg,parseWsMessage,buildOscMessage,forwardOscMessage(dual-destination dispatch, independent error handling),isNotableAddress,relayOscToClients(OPEN-state filtering, broadcast, JSON envelope),buildWelcomeMessageaudio-engine.test.js(41 tests) — Web Audio API mocked end-to-end:initialize(idempotency,webkitAudioContextfallback),playNote(MIDI→Hz, partial count, probability amplitudes, harmonic series, spin/coherence mapping),stopNote(release ramp timing, oscillator shutdown after timer elapses),setMasterVolume,setReverbMix,resumestubs.test.js(71 tests) —OSCClientandMIDIBridge: all send methods (OSC addresses, arg ordering),connect()handler wiring, MIDI CC mappings (CC 1/10/74/91/123), 14-bit pitch bend, 7-bit masking,initialize()via mocked Web MIDI APIPython tests (
tests/)test_eigenstate_ableton.py(37 tests) —parse_osc_string(padding, offsets, UTF-8),parse_osc_message(int/float/multi-arg, malformed, truncated), CC mappings (coherence→reverb, spin→pan, energy→filter — boundary values and clamping),_handle_oscrouting for all 5 address types with short-arg defaultstest_touchdesigner_receiver.py(35 tests) — all 8handle_messagebranches with guard-clause coverage,onFrameStartflash decay (exact factors 0.85/0.75, convergence to zero)Implementations
src/osc-client.js— implemented from stub: WebSocket connection management, all 9 send methods with correct OSC addresses and arg orderingsrc/midi-bridge.js— implemented from stub: Web MIDI API initialization,noteOn/noteOffwith 7-bit masking, CC mappings mirroring the Ableton Remote Script (CC 1 probability, CC 10 pan/spin, CC 74 filter/energy, CC 91 reverb/coherence, CC 123 all-notes-off), 14-bit pitch bend for tunnelingInfrastructure
.github/workflows/test.yml— CI runsnpm run test:coverage(Node 20) andpython -m pytest(Python 3.11) on every push and PRpackage.json— Jest configured with coverage thresholds (85% global statements/lines, 95% forquantum-engine.js)pytest.ini— pytest configured to discovertests/README.md— Testing section addedBug fix
src/osc-client.jsconnect()— the originalrequire('ws')fallback would throw aReferenceErrorin any browser environment where nativeWebSocketis absent andrequireis also not defined. Fixed to guard withtypeof require !== 'undefined'before calling it.Refactors (test-enabling only)
osc/bridge.js— extractednormalizeOscArg,parseWsMessage,buildOscMessage,forwardOscMessage,isNotableAddress,relayOscToClients,buildWelcomeMessageas named exports; wrapped server startup inif (require.main === module)so the file can be safelyrequire()d in testssrc/quantum-engine.js,src/audio-engine.js,src/osc-client.js,src/midi-bridge.js— addedmodule.exportsconditional for Node.js test environments