-
Notifications
You must be signed in to change notification settings - Fork 357
Miscellaneous Fixes #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous Fixes #619
Conversation
…g-in-codebase Fix quoting for RemoteApp name
…ment Fix privileges typo in setup comments
…setup.sh Fix typo in setup info comments
Fix grammar in README
…ams.ps1-comment Fix comment typo
Fix typo in README
…section Fix typo in docs
…comment Fix user source comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing because the patches from the Nix package no longer apply, we need to address that before merging. Otherwise, this looks good.
Also, I got prompted to install https://github.com/apps/chatgpt-connector on the org. Is that so codex can access PRs like Copilot does? I'd be willing to add it right away if it's only manual access but if this does like auto-reviews or something we should consult some more people for opinions |
@oskardotglobal Was trying out Codex for the first time today and was exploring some of the integration features. I think it’s probably safest to decline the request for now. Better to keep things restricted to my own fork in case it does something unexpected upstream. Cheers. |
…-if-exist-syntax Fix conditional in OEM install script from `if exists` to `if exist`.
Fix grammar in detected file comment
…ing-corrections Fix minor grammar in docker setup docs
…mple-in-compose.yaml Fix compose disk mapping comment
…mmatical-correction Fix minor grammar issue in license
…xremovablemedia Update removable media comment
![]() Commit e803794 improves |
Nice. I actually replaced install.bat with a powershell script in #308, but this would be nice for non-docker setups |
…son-with-string-inequality Fix string comparison in setup.sh
fixed erroneous comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Garnix says it's building so your patch seems to work.
OpenAI's 'Codex' found various typos and one minor issue with variable quoting.