feat: add resilience to pool timeout in flow update #6412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
- Add retry logic using backon for critical sqlx queries in update_flow_status_after_job_completion_internal - Create retry_sqlx! macro for consistent retry behavior (3 attempts, 200ms delay) - Apply retry logic to: - Initial flow status fetch query (prevents function failure on pool timeout) - Flow jobs results retrieval query (ensures proper job results collection) - Improves workflow reliability by handling temporary database connectivity issues 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
Deploying windmill with
|
| Latest commit: |
b6b5502
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://de19050e.windmill.pages.dev |
| Branch Preview URL: | https://claude-issue-6408-20250819-0.windmill.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds retry logic using backon to critical sqlx queries in
update_flow_status_after_job_completion_internalto handle database pool timeouts and improve workflow reliability.Changes
retry_sqlx!macro for consistent retry behavior (3 attempts, 200ms delay)Technical Details
The implementation focuses on queries outside transactions (safer to retry) and targets the most critical queries that would cause workflow failures. Uses proven retry patterns from existing codebase with minimal invasive changes.
File modified:
backend/windmill-worker/src/worker_flow.rsImpact
Fixes #6408
Generated with Claude Code