feat: add path autocomplete for scripts and flows#7751
Open
N48LL wants to merge 2 commits intowindmill-labs:mainfrom
Open
feat: add path autocomplete for scripts and flows#7751N48LL wants to merge 2 commits intowindmill-labs:mainfrom
N48LL wants to merge 2 commits intowindmill-labs:mainfrom
Conversation
N48LL
requested review from
alpetric,
hugocasa and
rubenfiszel
as code owners
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| let inputEl: HTMLInputElement | undefined = $state() | ||
|
|
||
| async function loadPaths() { | ||
| if (loaded || !workspace || !['script', 'flow', 'app'].includes(kind)) return |
Contributor
There was a problem hiding this comment.
Review: The loadPaths() function restricts fetching paths to types 'script', 'flow', and 'app'. Confirm that this is the intended behavior and consider adding a comment or documentation if more types are to be supported in the future.
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Thanks for the contribution @diegoimbert can you take a look please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds path autocomplete to the name input field when creating scripts and flows. After selecting a folder, focusing the name input shows existing subfolders as suggestions, making it easier to navigate nested folder structures.
The component fetches paths from both scripts and flows so folders are visible regardless of which type created them. Only shows directory suggestions (not filenames) for clean level-by-level navigation.
Adding the same for resources and variables would require new backend endpoints (resources/list_paths, variables/list_paths) since the current list endpoints return full objects with values, which would be inefficient and potentially insecure for this purpose. But let's see if this feature is even welcome first. For our team it would help a lot as we manage dozens of client integrations with many customer specific resources and secrets organized in the same multi-level folder structure.