feat: explicitly use hoisted linker for bun install#7840
Draft
rubenfiszel wants to merge 2 commits intomainfrom
Draft
feat: explicitly use hoisted linker for bun install#7840rubenfiszel wants to merge 2 commits intomainfrom
rubenfiszel wants to merge 2 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying windmill with
|
| Latest commit: |
0e5c234
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d9f76e65.windmill.pages.dev |
| Branch Preview URL: | https://feat-bun-install-hoisted-lin.windmill.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bun 1.3+ introduced isolated installs as an alternative to the traditional hoisted layout. While the default for single-package projects is currently hoisted, this has changed multiple times across bun versions (1.3 switched to isolated, 1.3.2 reverted). This PR explicitly passes
--linker hoistedto allbun installinvocations to protect against future default changes.Changes
--linker hoistedtobun installininstall_bun_lockfile()(bun_executor.rs)--linker hoistedtobun installinprepare_deps_standalone()(prepare_deps.rs)test_bun_job_with_cowsay_depverifying npm dependency installation works correctly with hoisted linkerTest plan
cargo check -p windmill-workercompiles cleanlyKEEP_JOB_DIR=true cargo test --test bun_jobs test_bun_job_with_cowsay_deppassesnode_modules/: 29 packages flat at top level, no.bun/directory, no symlinks — confirms hoisted layoutGenerated with Claude Code