Conversation
|
Claude finished @rubenfiszel's task in 46s —— View job Review of PR #7915 — CI speed tests
This PR makes four changes to
FeedbackRunner change (ubicloud → Blacksmith 32 vCPU ARM) Switching to a 32 vCPU ARM runner from a 16 vCPU x86 runner should significantly improve both compilation and test execution times. One thing to verify: since this is an ARM runner, all language runtimes and tools installed in the workflow (Deno, Bun, Go, PHP, .NET, Ruby, PowerShell, DuckDB FFI build) need to have ARM64 builds available. Most of these do, but worth confirming the CI run passes end-to-end — particularly the DuckDB FFI native build ( Enabling Rust toolchain cache Enabling Commenting out With the explicit limit removed, Cargo will default to the number of logical CPUs (32 on this runner). This makes sense — the previous limit of 12 was appropriate for 16 vCPU, and letting Cargo auto-detect on 32 vCPU should improve compilation parallelism. An alternative would be to set it explicitly to 32 (or slightly less to leave headroom for services), but auto-detect is fine for CI. If you prefer to keep it explicit for documentation purposes, you could set it to Bumping test threads from 10 to 12 A modest increase. With 32 vCPUs available, there may be room to go higher (e.g., 16 or even 20), depending on whether tests have resource contention (DB connections, ports, file locks). Worth experimenting with higher values in follow-up runs to find the sweet spot. SummaryThe changes are straightforward and well-motivated. No correctness or security concerns. The main risk is the architecture change to ARM64 — this should be validated by the CI run on this PR. If the run passes green, this is good to merge. Test instructionsThese are CI-only changes — there are no app-facing changes. To verify: check the GitHub Actions run for this PR's branch and confirm the backend test job completes successfully on the new Blacksmith ARM runner with a faster wall-clock time compared to recent runs on |
.github/workflows/backend-test.yml
Outdated
| jobs: | ||
| cargo_test: | ||
| runs-on: ubicloud-standard-16 | ||
| runs-on: blacksmith-32vcpu-ubuntu-2404-arm |
There was a problem hiding this comment.
Runner changed to ARM-based "blacksmith-32vcpu-ubuntu-2404-arm". Verify all dependencies support ARM architecture.
| WMDEBUG_FORCE_RUNNABLE_SETTINGS_V0: 1 | ||
| WMDEBUG_FORCE_NO_LEGACY_DEBOUNCING_COMPAT: 1 | ||
| TEST_NPM_REGISTRY: "http://localhost:4873/:_authToken=${{ env.NPM_TOKEN }}" | ||
| run: | |
There was a problem hiding this comment.
Increased '--test-threads' from 10 to 12 in the cargo test command. Verify that 12 threads are optimal for the current runner.
Deploying windmill with
|
| Latest commit: |
a9bac09
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89720eb9.windmill.pages.dev |
| Branch Preview URL: | https://rf-testbackendtest.windmill.pages.dev |
No description provided.