Repository navigation
docs: explain colorize must be a format, not a Console option - #2640
Open
TrueFurina wants to merge 1 commit into
Open
TrueFurina wants to merge 1 commit into
TrueFurina wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per #1095: users try
colorize: trueas a Console transport option and see no colors. Documents thatcolorizeis a format, not a transport option.Changes
docs/transports.md: new "#### Colorizing Console output" subsection under the Console Transport section:colorizeis a format and must be composed intoformat(logger or transport level)combine(colorize(), timestamp(), printf(...))examplecolorize()placed after aprintf/message-composing formatter has no visible effect, matching the root cause in the issue (colors applied to the already-final message)Verification