Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container.close('')currently closes every logger because it treats an empty-string ID as an omitted argument. Recognize this ID explicitly so only its logger is closed, or nothing happens if it is absent.Adds regressions for existing and missing empty-string IDs, plus controls for
close()andclose(null). Other falsy argument behavior is unchanged.Validation: 238 unit tests and coverage thresholds pass on Node 22, 24 and 26; each integration run passes 3 tests. Lint, TypeScript and Babel build pass. Both regressions fail before the fix.
On macOS, the full unit suite leaves an existing timer open in
tail-file.test.js, reproduced on unmodified source. Node 22/26 runs used--forceExitafter all assertions and coverage checks; the focused container suite exits normally.