Repository navigation
Conversation
Co-authored-by: Bennett Payoyo <Yahiro025@users.noreply.github.com>
Co-authored-by: Bennett Payoyo <Yahiro025@users.noreply.github.com>
Co-authored-by: Bennett Payoyo <Yahiro025@users.noreply.github.com>
Co-authored-by: Bennett Payoyo <Yahiro025@users.noreply.github.com>
| if (this.transports.length) { | ||
| this.transports.forEach(transport => { | ||
| if (typeof transport.close === 'function') { | ||
| transport.close(); |
There was a problem hiding this comment.
This line closes each transport directly, and this.clear() unpipes it, so TransportStream's unpipe handler calls close() a second time. A transport that throws on a repeated close call breaks reconfiguration.
Author
There was a problem hiding this comment.
Good catch — thanks. TransportStream already calls close() from its unpipe handler, so the direct close + clear() path was closing twice.
Pushed 883c6b5: we still end each transport before clear() (keeps the #1573 write-after-end fix), but temporarily hide close so unpipe does not invoke it again. Added a regression test where a second close() throws.
TransportStream calls close() again when a transport is unpiped, so configure's direct close() ran twice. Hide close() until clear() finishes so File streams still end before unpipe without a second close. Co-authored-by: Bennett Payoyo <Yahiro025@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1573. On
logger.configure({ transports }), close/end existing File transports before clearing and attaching new ones so pending writes never hit an ended stream (Error: write after end).Test plan
test/unit/winston/logger.test.jsfor reconfiguration / close-before-clear behavior