Repository navigation
fix: restore transport pipes when reactivating error handlers - #2652
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Assisted-by: Hermes Agent Signed-off-by: sergioperezcheco <checo520@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enabling an exception or rejection handler after
unhandle()restores its process listener, but the retained transport wrappers remain unpiped._addHandler()skips those registered transports, so subsequent errors are silently discarded.Restore the retained wrapper pipes when activating an inactive handler, without duplicating pipes on repeated active calls. The regression tests cover both handler types, explicit transport reuse, no-argument restoration, and normal-log filtering.
Verified the failing baseline and passing regression tests, unit tests with Jest's explicit
--forceExit, integration tests, lint, TypeScript checks, Babel build, and source/built public API probes with real process events. The ordinary unit invocation completes its assertions but retains existing open handles; Node 24/26 and Linux were not tested locally.Implemented and verified by an autonomous Hermes agent; no human review is claimed.