Skip to content

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Oct 6, 2025

TaskWPB-20265 [Android] Meeting list items for all states


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Created UIMeeting model class with preview mocks and MeetingItem composable with all required elements:
    • title,
    • start/end/duration info
    • repeating interval info label
    • meeting “belonging” (group, channel, 1:1 or groupiess meeting)
    • “starting soon” counter
    • “attending” indicators
    • “join” button
  • Moved remaining theme extension functions and group/channel avatar composables with some resources to common module
  • Extracted “overlapping avatars row” into a separate adjustable composable in common module
  • Fixed some “border” colors - changed to outline
  • Fixed avatar sizes so that the border does not extend beyond the specified size and avatar with border is of size 32x like on designs
  • Improved private channel avatar so that the lock icon scales with the avatar
  • Added some parameters to adjust RowItemTemplate, removed redundant one and fixed some paddings, mainly for “actions” buttons section
image
Screen_recording_20251006_171334.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.77%. Comparing base (2c7210d) to head (1534239).

Files with missing lines Patch % Lines
...kotlin/com/wire/android/util/DateAndTimeParsers.kt 75.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4325      +/-   ##
===========================================
+ Coverage    47.76%   47.77%   +0.01%     
===========================================
  Files          525      525              
  Lines        17930    17938       +8     
  Branches      2952     2952              
===========================================
+ Hits          8564     8570       +6     
- Misses        8483     8485       +2     
  Partials       883      883              
Files with missing lines Coverage Δ
...kotlin/com/wire/android/util/DateAndTimeParsers.kt 74.19% <75.00%> (+0.11%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7210d...1534239. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

sonarqubecloud bot commented Oct 8, 2025

@MohamadJaara MohamadJaara added this pull request to the merge queue Oct 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 9, 2025
@saleniuk saleniuk added this pull request to the merge queue Oct 9, 2025
Merged via the queue into develop with commit 419e55d Oct 9, 2025
15 of 16 checks passed
@saleniuk saleniuk deleted the feat/meetings/meeting_list_items branch October 9, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants