Skip to content

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Oct 7, 2025

TaskWPB-20264 [Android] Lists of Meetings with groups (Ongoing, Today, and Tomorrow)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Changed names of "folderWithElements" and "FolderHeader" functions and composables to use "section" instead of "folder" as it's confusing since we already have conversation folders implemented (It's been marked as // TODO needs renaming for almost a year).
Moved these functions with resources to the common module so that they can be reused in other modules.
Added new section with a "Big" prefix that's used for instance to group meetings by days.
Changed the appearance of expandable section header to match current designs and moved the checkbox to the left for the selectable participant list items.

Before After Designs

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 26.92308% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.76%. Comparing base (2c7210d) to head (3af3afa).

Files with missing lines Patch % Lines
...ome/conversationslist/ConversationListViewModel.kt 15.38% 11 Missing ⚠️
...s/participants/GroupConversationParticipantList.kt 0.00% 4 Missing ⚠️
...ome/conversationslist/model/ConversationSection.kt 50.00% 2 Missing ⚠️
...ui/home/conversationslist/ConversationListState.kt 50.00% 1 Missing ⚠️
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (26.92%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4328   +/-   ##
========================================
  Coverage    47.76%   47.76%           
========================================
  Files          525      525           
  Lines        17930    17930           
  Branches      2952     2952           
========================================
  Hits          8564     8564           
  Misses        8483     8483           
  Partials       883      883           
Files with missing lines Coverage Δ
...ations/details/options/GroupConversationOptions.kt 0.00% <ø> (ø)
...d/ui/home/conversations/media/FileAssetsContent.kt 0.00% <ø> (ø)
.../ui/home/conversations/media/ImageAssetsContent.kt 0.00% <ø> (ø)
...i/home/conversationslist/model/ConversationItem.kt 54.46% <ø> (ø)
...ndroid/ui/sharing/ImportMediaAuthenticatedState.kt 85.71% <100.00%> (ø)
...in/com/wire/android/util/ui/SectionWithElements.kt 0.00% <ø> (ø)
...ui/home/conversationslist/ConversationListState.kt 40.00% <50.00%> (ø)
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 35.92% <50.00%> (ø)
...ome/conversationslist/model/ConversationSection.kt 37.50% <50.00%> (ø)
...s/participants/GroupConversationParticipantList.kt 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7210d...3af3afa. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saleniuk saleniuk requested review from sbakhtiarov and MohamadJaara and removed request for sbakhtiarov October 7, 2025 15:23
Copy link

sonarqubecloud bot commented Oct 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants