feat: chat bubbles - reactively update sender name - WPB-19514 #3455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/CB-4-update-sender-name # Conflicts: # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesDataSource.swift
# Conflicts: # WireMessaging/Sources/WireMessagingDomain/Conversation/MessageModel.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesDataSource.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesViewController.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesViewModel.swift # WireMessaging/Sources/WireMessagingUI/Conversation/Message Views/TextMessageView/TextMessageViewModel.swift # WireMessaging/Sources/WireMessagingUI/Conversation/MessageType.swift # WireMessaging/Sources/WireMessagingUI/Conversation/MessageUpdateType.swift # WirePreviewApps/WIreChatBubbles/SceneDelegate.swift # WirePreviewApps/WirePreviewApps.xcodeproj/project.pbxproj # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/ConversationViewController.swift
…B-3-handle-message-send-WPB-19373
…e/CB-4-update-sender-name
Test Results2 003 tests 1 976 ✅ 2m 20s ⏱️ Results for commit e12c337. ♻️ This comment has been updated with latest results. |
dmitrysimkin
commented
Aug 13, 2025
dmitrysimkin
changed the title
# Conflicts: # WireMessaging/Sources/WireMessagingAssembly/ConversationsAssembly.swift # WireMessaging/Sources/WireMessagingDomain/Conversation/LoadConversationMessagesUseCase.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesDataSource.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesViewController.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesViewModel.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/LoadConversationMessagesRepository.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/ConversationViewController.swift
…e/CB-4-update-sender-name
dmitrysimkin
requested review from
a team,
jullianm and
samwyndham
and removed request for
a team
samwyndham
reviewed
Aug 18, 2025
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/MessagesIndividualUpdatesFactory.swift
Show resolved
Hide resolved
Base automatically changed from
feature/CB-3-handle-message-send-WPB-19373
to
develop
August 21, 2025 15:52
# Conflicts: # WireMessaging/Sources/WireMessagingAssembly/ConversationsAssembly.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationDataSource.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesViewController.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/ConversationViewController.swift
jullianm
approved these changes
Aug 22, 2025
| self.state = state | ||
| namePublisher?.sink { [weak self] name in | ||
| self?.state = .exists(AttributedString(name)) | ||
| }.store(in: &cancellables) |
There was a problem hiding this comment.
question: no risk of having a binding still active when a view is reused ? probably works differently in SwiftUI but on UIKit we could have these issues with reusable cells if we didn't clear out the subscriptions which could mess the UI.
samwyndham
approved these changes
Aug 29, 2025
samwyndham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Added logic to handle when user name changed, by introducing one publisher per user (one subject and sever cell's view models as subscribers.
Testing
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-13.at.18.50.17.mp4