-
Notifications
You must be signed in to change notification settings - Fork 24
chore: single locator constants file to be used for UI and main tests #3604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results1 907 tests 1 880 ✅ 2m 24s ⏱️ Results for commit 24a49c8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was to use the constants within the app, here the first part is done with using in the UITests. I expect the code within the app to be updated to merge this PR
|
||
public enum Locators { | ||
|
||
public enum Buttons { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: I wonder if that makes sense this organisation per type rather than per domain / page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense by type as there are some bottom sheet pages which has 1 or 2 usable elements + will be avoided duplicate elements like next confirm OK etc across various pages.
New PR created #3653 as approach changed. |
Issue
Issue to have separate locators for UI and main tests and some repetive locators against every page like OK, Done etc.
Changes
All the locators from page class now moved to a foundation file Locators.swift by which the same element can be used for both UI and main tests.
Testing
Ran all UI tests locally and worked fine

Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: