Skip to content

Conversation

findms
Copy link
Contributor

@findms findms commented Sep 18, 2025

TaskWPB-20289 [iOS/QA] Store all locators to a common file with common target to be available and used in Main+ UI tests

Issue

Issue to have separate locators for UI and main tests and some repetive locators against every page like OK, Done etc.

Changes

All the locators from page class now moved to a foundation file Locators.swift by which the same element can be used for both UI and main tests.

Testing

Ran all UI tests locally and worked fine
image

Optional: attachments like images, videos, etc.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@findms findms changed the title single locator file single locator file WPB-20289 Sep 18, 2025
@findms findms changed the title single locator file WPB-20289 chore: single locator file WPB-20289 Sep 18, 2025
@findms findms added the QA label Sep 18, 2025
@findms findms changed the title chore: single locator file WPB-20289 chore: single locator file - WPB-20289 Sep 18, 2025
@findms findms changed the title chore: single locator file - WPB-20289 chore: single locator constants - WPB-20289 Sep 18, 2025
@findms findms changed the title chore: single locator constants - WPB-20289 chore: single locator constants - WPB-20289 Sep 18, 2025
@findms findms changed the title chore: single locator constants - WPB-20289 chore: single locator constants file - WPB-20289 Sep 23, 2025
@findms findms marked this pull request as ready for review September 23, 2025 14:46
@findms findms changed the title chore: single locator constants file - WPB-20289 chore: single locator constants file to be used for UI and main tests - WPB-20289 Sep 23, 2025
Copy link
Contributor

Test Results

1 907 tests   1 880 ✅  2m 24s ⏱️
  307 suites     27 💤
    2 files        0 ❌

Results for commit 24a49c8.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to use the constants within the app, here the first part is done with using in the UITests. I expect the code within the app to be updated to merge this PR


public enum Locators {

public enum Buttons {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: I wonder if that makes sense this organisation per type rather than per domain / page

Copy link
Contributor Author

@findms findms Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense by type as there are some bottom sheet pages which has 1 or 2 usable elements + will be avoided duplicate elements like next confirm OK etc across various pages.

@findms findms changed the title chore: single locator constants file to be used for UI and main tests - WPB-20289 chore: single locator constants file to be used for UI and main tests Sep 26, 2025
@findms
Copy link
Contributor Author

findms commented Sep 30, 2025

New PR created #3653 as approach changed.

@findms findms closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants