feat(cells): delete message with files - WPB-19433 #3712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jullianm
requested review from
a team,
netbe and
samwyndham
and removed request for
a team
jullianm
commented
Oct 8, 2025
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/MessageAction.swift
Outdated
Show resolved
Hide resolved
Test Results2 059 tests 2 032 ✅ 2m 11s ⏱️ Results for commit c78ee91. ♻️ This comment has been updated with latest results. |
…ire-ios into feat/delete-message-with-files
samwyndham
reviewed
Oct 10, 2025
There was a problem hiding this comment.
question: @jullianm Why is there a need to attach the closure to the delete action. Can't everything be done in ConversationContentViewController.messageAction(actionId:for:view:)?
|
@samwyndham you're completely right, the closure is useless, I'll revert these changes and keep the rest, thanks! |
|
@samwyndham removed unnecessary code in 8b33bcb |
netbe
changed the title
netbe
changed the title
netbe
reviewed
Oct 13, 2025
...ces/UserInterface/Conversation/Content/ConversationContentViewController+MessageAction.swift
Outdated
Show resolved
Hide resolved
...face/Conversation/ConversationViewController+ConversationContentViewControllerDelegate.swift
Outdated
Show resolved
Hide resolved
...face/Conversation/ConversationViewController+ConversationContentViewControllerDelegate.swift
Outdated
Show resolved
Hide resolved
samwyndham
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Looks good. Approving assuming @netbes comments are addressed.
...ces/UserInterface/Conversation/Content/ConversationContentViewController+MessageAction.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR handles deletion of files (WireCells) on multipart messages sent in a conversation, specifically it covers the following use cases:
Files should be deleted when opening the Files view.
Note: As aligned with web client, when deleting a message for self user only, message and files will disappear from the conversation however files will still show up in the Files view.
Testing
Above use cases were tested.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: